Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Getting Started guide for logging data #4052

Merged
merged 7 commits into from
Oct 30, 2023
Merged

C++ Getting Started guide for logging data #4052

merged 7 commits into from
Oct 30, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 27, 2023 •
edited by github-actions bot
Loading

What

Port the rust guide over to cpp.

Since we don't have docs generated I linked to the header files in github which is less than great for maintainability but seems better than no links at all.

Preview

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 27, 2023
@jleibs jleibs marked this pull request as ready for review October 27, 2023 21:28
emilk
emilk approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

docs/content/getting-started/logging-cpp.md Outdated Show resolved Hide resolved
docs/content/getting-started/logging-cpp.md Outdated Show resolved Hide resolved
docs/content/getting-started/logging-cpp.md Outdated Show resolved Hide resolved
docs/content/getting-started/logging-cpp.md Outdated Show resolved Hide resolved
docs/content/getting-started/logging-cpp.md Outdated Show resolved Hide resolved
emilk
emilk reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of overlap with docs/content/getting-started/cpp.md, but 🤷

@emilk emilk mentioned this pull request Oct 30, 2023
Closed
33 tasks
@jleibs jleibs merged commit 71fc14f into main Oct 30, 2023
34 checks passed
@jleibs jleibs deleted the jleibs/getting_started_logging_cpp branch October 30, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleibs @emilk