Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.74.0 #4390

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Update Rust to 1.74.0 #4390

merged 6 commits into from
Nov 30, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 29, 2023

What

I'm mostly after needless_pass_by_ref_mut lint (added in 1.73.0) which didn't even trigger so far 😮. But useful for my current stream of work of making things more interior mutable.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to turning on more clippy lints!

crates/re_string_interner/src/lib.rs Show resolved Hide resolved
tests/rust/log_benchmark/src/image.rs Show resolved Hide resolved
@Wumpf
Copy link
Member Author

Wumpf commented Nov 30, 2023

I'm looking forward to turning on more clippy lints!

Ah right. I wasn't fully aware that many clippy lints are opt-in. Like the one I pointed out. Taking that separately

@Wumpf Wumpf merged commit a4bb250 into main Nov 30, 2023
40 of 41 checks passed
@Wumpf Wumpf deleted the andreas/rust-update branch November 30, 2023 08:55
emilk pushed a commit that referenced this pull request Feb 14, 2024
…amples (#5195)

### What

The last rust update in 
* #4390

didn't catch a whole bunch of places.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5195/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5195)
- [Docs
preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf added a commit that referenced this pull request Feb 21, 2024
…amples (#5195)

### What

The last rust update in 
* #4390

didn't catch a whole bunch of places.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5195/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5195)
- [Docs
preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants