Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC improvements 2: VecDeque extensions & benchmarks #4396

Merged
merged 6 commits into from
Dec 2, 2023
Merged

GC improvements 2: VecDeque extensions & benchmarks #4396

merged 6 commits into from
Dec 2, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 30, 2023 •
edited by github-actions bot
Loading

What the title says: just introducing new tools that will be used by all the ringbuffer looking things in the revamped datastore and upcoming query cache.

Part of the GC improvements series:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 📉 performance Optimization, memory use, etc do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 30, 2023
This was referenced Nov 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@teh-cmc teh-cmc force-pushed the cmc/gc_improvements_1_sorted_timeless branch from 6828177 to 5b7ab98 Compare November 30, 2023 11:24
@teh-cmc teh-cmc force-pushed the cmc/gc_improvements_2_vecdeque_extensions branch from 309a3d4 to c41aebb Compare November 30, 2023 11:27
@teh-cmc teh-cmc marked this pull request as ready for review November 30, 2023 11:27
Wumpf
Wumpf approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VecDeque on steroids!! 😄

crates/re_log_types/src/vec_deque_ext.rs Outdated
v.rotate_left(1);
assert!(v.is_sorted());

assert!(v.is_sorted()); // !
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's up with this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there used to be tricky stuff going on, but not anymore 😶 removing

crates/re_log_types/src/vec_deque_ext.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc force-pushed the cmc/gc_improvements_2_vecdeque_extensions branch from de1c851 to a3f5046 Compare November 30, 2023 14:17
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Dec 2, 2023
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 0: use-case driven benchmarks (#4394)
9a9d990 
Introduce 2 new benchmark suites that drive the development of this PR
series:
1. Logging a tons of scalars, in order, across a bunch of series,
themselves scattered across a bunch of plots.
2. Logging a tons of timeless data, across a bunch of entities.

### Benchmarks

Hint: it's bad.

```
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    1.00   1084.0±4.47ms 54.1 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    1.00       2.1±0.02s 27.6 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     1.00    465.8±2.50ms 125.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     1.00    655.3±2.61ms 89.4 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          1.00    652.8±4.12ms 89.8 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         1.00       2.4±0.05s 24.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         1.00       2.4±0.03s 24.1 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          1.00       2.5±0.08s 23.5 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          1.00       2.4±0.02s 24.5 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               1.00       2.4±0.03s 24.4 KElem/sec
```

---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
@teh-cmc teh-cmc force-pushed the cmc/gc_improvements_1_sorted_timeless branch from 3a163cd to 3e18fe1 Compare December 2, 2023 11:51
Base automatically changed from cmc/gc_improvements_1_sorted_timeless to main December 2, 2023 11:52
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 1: fix timeless tables not being RowId-ordered (#4395)
75c232b 
Fixes a long-standing bug: timeless tables not being sorted by `RowId`,
which means they effectively always return incorrect results for
out-of-order data (yes, that is a thing even in a timeless context).

This _worsens_  GC performance for timeless tables, but:
1. The performance of incorrect code hardly matters to begin with, and
2. this is ground work for turning timeless tables in ringbuffers in an
upcoming PR, which will massively improve performance.

- Fixes #1807 

### Benchmarks

Hint: it's even worse!

```
group                                                     gc_improvements_0                       gc_improvements_1
-----                                                     -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    1.00   1084.0±4.47ms 54.1 KElem/sec     1.03   1117.2±9.07ms 52.4 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    1.00       2.1±0.02s 27.6 KElem/sec     1.01       2.1±0.01s 27.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     1.00    465.8±2.50ms 125.8 KElem/sec    1.01    471.5±4.76ms 124.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     1.00    655.3±2.61ms 89.4 KElem/sec     1.02    666.7±6.64ms 87.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          1.00    652.8±4.12ms 89.8 KElem/sec     1.02    665.6±4.67ms 88.0 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         1.00       2.4±0.05s 24.2 KElem/sec     3.35       8.1±0.10s  7.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         1.00       2.4±0.03s 24.1 KElem/sec     3.30       8.0±0.09s  7.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          1.00       2.5±0.08s 23.5 KElem/sec     3.23       8.1±0.11s  7.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          1.00       2.4±0.02s 24.5 KElem/sec     3.38       8.1±0.11s  7.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               1.00       2.4±0.03s 24.4 KElem/sec     3.35       8.1±0.07s  7.3 KElem/sec

```

---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
@teh-cmc teh-cmc force-pushed the cmc/gc_improvements_2_vecdeque_extensions branch from a3f5046 to 552fe04 Compare December 2, 2023 11:52
@teh-cmc teh-cmc merged commit 7da6b27 into main Dec 2, 2023
9 of 18 checks passed
@teh-cmc teh-cmc deleted the cmc/gc_improvements_2_vecdeque_extensions branch December 2, 2023 11:52
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 3: turn datastore columns into ring-buffers (#4397)
0d81047 
This turns every single column in `DataStore`/`DataTable` into a
ringbuffer (`VecDeque`).

This means that on the common/happy path of data being ingested in
order:
1. Inserting new rows doesn't require re-sorting the bucket (that's
nothing new), and
2. garbage collecting rows doesn't require re-sorting the bucket nor
copying anything (that's very new).

This leads to very significant performance improvements on the common
path.

- Fixes #1823 

### Benchmarks

Compared to `main`:
```
group                                                     gc_improvements_0                       gc_improvements_3
-----                                                     -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    4.50   1084.0±4.47ms 54.1 KElem/sec     1.00    241.0±1.66ms 243.1 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    8.86       2.1±0.02s 27.6 KElem/sec     1.00    239.9±2.70ms 244.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     1.88    465.8±2.50ms 125.8 KElem/sec    1.00    247.4±3.94ms 236.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     2.72    655.3±2.61ms 89.4 KElem/sec     1.00    241.2±2.06ms 243.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          2.72    652.8±4.12ms 89.8 KElem/sec     1.00    239.6±1.98ms 244.6 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         40.21      2.4±0.05s 24.2 KElem/sec     1.00     60.3±1.16ms 972.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         40.08      2.4±0.03s 24.1 KElem/sec     1.00     60.8±1.14ms 964.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          40.97      2.5±0.08s 23.5 KElem/sec     1.00     61.0±1.99ms 960.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          39.45      2.4±0.02s 24.5 KElem/sec     1.00     60.6±1.45ms 966.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               41.78      2.4±0.03s 24.4 KElem/sec     1.00     57.6±0.35ms 1018.1 KElem/sec
```

Compared to previous PR:
```
group                                                     gc_improvements_1                       gc_improvements_3
-----                                                     -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    4.63   1117.2±9.07ms 52.4 KElem/sec     1.00    241.0±1.66ms 243.1 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    8.96       2.1±0.01s 27.3 KElem/sec     1.00    239.9±2.70ms 244.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     1.91    471.5±4.76ms 124.3 KElem/sec    1.00    247.4±3.94ms 236.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     2.76    666.7±6.64ms 87.9 KElem/sec     1.00    241.2±2.06ms 243.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          2.78    665.6±4.67ms 88.0 KElem/sec     1.00    239.6±1.98ms 244.6 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         134.66      8.1±0.10s  7.2 KElem/sec    1.00     60.3±1.16ms 972.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         132.44      8.0±0.09s  7.3 KElem/sec    1.00     60.8±1.14ms 964.3 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          132.22      8.1±0.11s  7.3 KElem/sec    1.00     61.0±1.99ms 960.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          133.27      8.1±0.11s  7.3 KElem/sec    1.00     60.6±1.45ms 966.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               140.04      8.1±0.07s  7.3 KElem/sec    1.00     57.6±0.35ms 1018.1 KElem/sec
```

---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 4: index EntityPathHashes in metadata registry (#4398)
1ce4563 
Indexes `EntityPathHash`es alongside `TimePoint`s in the metadata
registry to avoid having to run fullscans during garbage collection.

Yields some more significant wins in the common case.

### Benchmarks

Compared to `main`:
```
group                                                     gc_improvements_0                       gc_improvements_4
-----                                                     -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    10.32  1084.0±4.47ms 54.1 KElem/sec     1.00    105.0±0.91ms 558.1 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    19.80      2.1±0.02s 27.6 KElem/sec     1.00    107.3±0.83ms 546.2 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     4.38    465.8±2.50ms 125.8 KElem/sec    1.00    106.3±0.74ms 551.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     6.16    655.3±2.61ms 89.4 KElem/sec     1.00    106.4±0.94ms 550.6 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          6.34    652.8±4.12ms 89.8 KElem/sec     1.00    102.9±0.75ms 569.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         37.12      2.4±0.05s 24.2 KElem/sec     1.00     65.3±0.81ms 897.6 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         37.54      2.4±0.03s 24.1 KElem/sec     1.00     64.9±1.07ms 903.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          38.81      2.5±0.08s 23.5 KElem/sec     1.00     64.4±0.99ms 910.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          37.00      2.4±0.02s 24.5 KElem/sec     1.00     64.6±1.08ms 906.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               36.82      2.4±0.03s 24.4 KElem/sec     1.00     65.3±1.29ms 897.3 KElem/sec
```

Compared to previous PR:
```
group                                                     gc_improvements_3                        gc_improvements_4
-----                                                     -----------------                        -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    2.30    241.0±1.66ms 243.1 KElem/sec     1.00    105.0±0.91ms 558.1 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    2.24    239.9±2.70ms 244.3 KElem/sec     1.00    107.3±0.83ms 546.2 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     2.33    247.4±3.94ms 236.8 KElem/sec     1.00    106.3±0.74ms 551.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     2.27    241.2±2.06ms 243.0 KElem/sec     1.00    106.4±0.94ms 550.6 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          2.33    239.6±1.98ms 244.6 KElem/sec     1.00    102.9±0.75ms 569.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         1.00     60.3±1.16ms 972.3 KElem/sec     1.08     65.3±0.81ms 897.6 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         1.00     60.8±1.14ms 964.3 KElem/sec     1.07     64.9±1.07ms 903.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          1.00     61.0±1.99ms 960.9 KElem/sec     1.06     64.4±0.99ms 910.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          1.00     60.6±1.45ms 966.9 KElem/sec     1.07     64.6±1.08ms 906.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               1.00     57.6±0.35ms 1018.1 KElem/sec    1.13     65.3±1.29ms 897.3 KElem/sec
```

---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 5: Store{Diff,Event} optimizations (#4399)
28d8336 
Optimize the creation of `StoreDiff`s and `StoreEvent`s, which turns out
to be a major cost in time series use cases, when it is common to
generate several millions of those on any single GC run.

Once again some pretty significant wins.

### Benchmarks

Compared to `main`:
```
group                                                     gc_improvements_0                       gc_improvements_5
-----                                                     -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    13.00  1084.0±4.47ms 54.1 KElem/sec     1.00     83.4±1.16ms 702.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    25.37      2.1±0.02s 27.6 KElem/sec     1.00     83.7±0.61ms 700.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     5.55    465.8±2.50ms 125.8 KElem/sec    1.00     84.0±0.50ms 697.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     7.94    655.3±2.61ms 89.4 KElem/sec     1.00     82.5±1.33ms 710.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          8.02    652.8±4.12ms 89.8 KElem/sec     1.00     81.4±0.94ms 720.0 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         35.87      2.4±0.05s 24.2 KElem/sec     1.00     67.5±2.21ms 867.5 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         35.91      2.4±0.03s 24.1 KElem/sec     1.00     67.8±1.86ms 863.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          37.02      2.5±0.08s 23.5 KElem/sec     1.00     67.5±1.43ms 868.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          35.47      2.4±0.02s 24.5 KElem/sec     1.00     67.4±1.40ms 869.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               36.00      2.4±0.03s 24.4 KElem/sec     1.00     66.8±0.85ms 877.3 KElem/sec
```

Compared to previous PR:
```
group                                                     gc_improvements_4                       gc_improvements_5
-----                                                     -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024    1.26    105.0±0.91ms 558.1 KElem/sec    1.00     83.4±1.16ms 702.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048    1.28    107.3±0.83ms 546.2 KElem/sec    1.00     83.7±0.61ms 700.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256     1.27    106.3±0.74ms 551.3 KElem/sec    1.00     84.0±0.50ms 697.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512     1.29    106.4±0.94ms 550.6 KElem/sec    1.00     82.5±1.33ms 710.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/default          1.26    102.9±0.75ms 569.4 KElem/sec    1.00     81.4±0.94ms 720.0 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024         1.00     65.3±0.81ms 897.6 KElem/sec    1.03     67.5±2.21ms 867.5 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048         1.00     64.9±1.07ms 903.2 KElem/sec    1.05     67.8±1.86ms 863.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256          1.00     64.4±0.99ms 910.2 KElem/sec    1.05     67.5±1.43ms 868.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512          1.00     64.6±1.08ms 906.9 KElem/sec    1.04     67.4±1.40ms 869.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/default               1.00     65.3±1.29ms 897.3 KElem/sec    1.02     66.8±0.85ms 877.3 KElem/sec
```

---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 6: introduce batched GC (#4400)
8e3cf2e 
Makes the GC capable of dropping entire buckets in one go when the
conditions are met (and they are pretty simple to meet in the common
case of in-order data).

Unfortunately, I couldn't make the batched GC match -- let alone improve
-- the performance of the standard GC.
I even have a branch with a parallel batched GC, and it's still slower:
the overhead of the batching datastructures just kills me everytime.
For that reason, batching is disabled by default.

I still want to commit the code so as to prevent it from rotting though,
so we can come back to it at a later time.
This introduces a slight performance deterioration on the non-batched
path, that's fine.

### Benchmarks

Compared to `main`:
```
group                                                                       gc_improvements_0                       gc_improvements_6
-----                                                                       -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/default                            7.62    652.8±4.12ms 89.8 KElem/sec     1.00     85.7±1.14ms 683.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256                       5.34    465.8±2.50ms 125.8 KElem/sec    1.00     87.2±0.55ms 671.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512                       7.12    655.3±2.61ms 89.4 KElem/sec     1.00     92.0±1.85ms 636.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024                      12.45  1084.0±4.47ms 54.1 KElem/sec     1.00     87.1±0.40ms 672.7 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048                      23.63      2.1±0.02s 27.6 KElem/sec     1.00     89.9±1.13ms 652.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256/gc_batching=true                                              1.00     98.6±0.82ms 594.2 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512/gc_batching=true                                              1.00     94.6±1.26ms 619.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024/gc_batching=true                                             1.00     93.2±1.29ms 628.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048/gc_batching=true                                             1.00     94.3±1.43ms 621.1 KElem/sec
.../timeless_logs/drop_at_least=0.3/default                                 33.30      2.4±0.03s 24.4 KElem/sec     1.00     72.2±2.46ms 811.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256                            35.16      2.5±0.08s 23.5 KElem/sec     1.00     71.1±2.31ms 824.5 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512                            35.08      2.4±0.02s 24.5 KElem/sec     1.00     68.1±1.20ms 859.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024                           36.86      2.4±0.05s 24.2 KElem/sec     1.00     65.7±0.87ms 891.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048                           35.99      2.4±0.03s 24.1 KElem/sec     1.00     67.7±1.33ms 865.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256/gc_batching=true                                                   1.00     68.7±1.40ms 853.1 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512/gc_batching=true                                                   1.00     67.3±0.32ms 870.8 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024/gc_batching=true                                                  1.00     67.7±1.21ms 865.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048/gc_batching=true                                                  1.00     67.6±1.31ms 866.6 KElem/sec
```

Compared to previous PR:
```
group                                                                       gc_improvements_5                       gc_improvements_6
-----                                                                       -----------------                       -----------------
.../plotting_dashboard/drop_at_least=0.3/default                            1.00     81.4±0.94ms 720.0 KElem/sec    1.05     85.7±1.14ms 683.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256                       1.00     84.0±0.50ms 697.8 KElem/sec    1.04     87.2±0.55ms 671.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512                       1.00     82.5±1.33ms 710.0 KElem/sec    1.11     92.0±1.85ms 636.8 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024                      1.00     83.4±1.16ms 702.9 KElem/sec    1.04     87.1±0.40ms 672.7 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048                      1.00     83.7±0.61ms 700.0 KElem/sec    1.07     89.9±1.13ms 652.0 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=256/gc_batching=true                                              1.00     98.6±0.82ms 594.2 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=512/gc_batching=true                                              1.00     94.6±1.26ms 619.3 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=1024/gc_batching=true                                             1.00     93.2±1.29ms 628.9 KElem/sec
.../plotting_dashboard/drop_at_least=0.3/bucketsz=2048/gc_batching=true                                             1.00     94.3±1.43ms 621.1 KElem/sec
.../timeless_logs/drop_at_least=0.3/default                                 1.00     66.8±0.85ms 877.3 KElem/sec    1.08     72.2±2.46ms 811.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256                            1.00     67.5±1.43ms 868.2 KElem/sec    1.05     71.1±2.31ms 824.5 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512                            1.00     67.4±1.40ms 869.4 KElem/sec    1.01     68.1±1.20ms 859.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024                           1.03     67.5±2.21ms 867.5 KElem/sec    1.00     65.7±0.87ms 891.4 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048                           1.00     67.8±1.86ms 863.9 KElem/sec    1.00     67.7±1.33ms 865.9 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=1024/gc_batching=true                                                  1.00     67.7±1.21ms 865.2 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=2048/gc_batching=true                                                  1.00     67.6±1.31ms 866.6 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=256/gc_batching=true                                                   1.00     68.7±1.40ms 853.1 KElem/sec
.../timeless_logs/drop_at_least=0.3/bucketsz=512/gc_batching=true                                                   1.00     67.3±0.32ms 870.8 KElem/sec
```

---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
teh-cmc added a commit that referenced this pull request Dec 2, 2023
@teh-cmc
GC improvements 7: introduce time_budget GC setting (#4401)
06872fe 
Adds a configurable time bound to the GC, in addition to the
pre-existing space bound.
```rust
/// How long the garbage collection in allowed to run for.
///
/// Trades off latency for throughput:
/// - A smaller `time_budget` will clear less data in a shorter amount of time, allowing for a
///   more responsive UI at the cost of more GC overhead and more frequent runs.
/// - A larger `time_budget` will clear more data in a longer amount of time, increasing the
///   chance of UI freeze frames but decreasing GC overhead and running less often.
///
/// The default is an unbounded time budget (i.e. throughput only).
pub time_budget: Duration,
```

No time budget:


https://github.com/rerun-io/rerun/assets/2910679/8ca63aa3-5ad4-4575-9486-21d805026c1e



3.5ms budget:


https://github.com/rerun-io/rerun/assets/2910679/e1bd1a41-6353-4a0e-90e5-8c05b76e92ea



---

Part of the GC improvements series:
- #4394
- #4395
- #4396
- #4397
- #4398
- #4399
- #4400
- #4401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf