Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove demo build script #4439

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Remove demo build script #4439

merged 3 commits into from
Dec 6, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Dec 5, 2023 •
edited by github-actions bot
Loading

What

Closes #4428
Closes #4277

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 5, 2023
@abey79 abey79 self-requested a review December 6, 2023 13:24
abey79
abey79 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've tested the build_screenshot_compare script just to be on the safe side and everything worked fine 👍🏻

@jprochazk jprochazk merged commit b17da35 into main Dec 6, 2023
40 checks passed
@jprochazk jprochazk deleted the jan/remove-demo-build-script branch December 6, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove build_demo_app.py Nuke demo.rerun.io
2 participants
@jprochazk @abey79