Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the sizes of some of the nightly examples #4545

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Limit the sizes of some of the nightly examples #4545

merged 2 commits into from
Dec 15, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 14, 2023 •
edited by github-actions bot
Loading

They are still not exactlty small, but a lot smaller, and since they all stream, it should be pretty fine anyways

detect_and_track_objects.rrd (55.3 MiB)
nuscenes.rrd (90.0 MiB)
objectron.rrd (81.1 MiB)
open_photogrammetry_format.rrd (67.6 MiB)
raw_mesh.rrd (116 kiB)
rgbd.rrd (36.8 MiB)
segment_anything_model.rrd (8.5 MiB)

This helped in figuring out what to focus on:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk
Limit the sizes of some of the nightly examples
ec5e91a 
They are still not exactlty _small_, but a lot _smaller_,
and since they all stream, it should be pretty fine anyways

```
detect_and_track_objects.rrd (55.3 MiB)
nuscenes.rrd (90.0 MiB)
objectron.rrd (81.1 MiB)
open_photogrammetry_format.rrd (67.6 MiB)
raw_mesh.rrd (116 kiB)
rgbd.rrd (36.8 MiB)
segment_anything_model.rrd (8.5 MiB)
```
@emilk emilk added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 14, 2023
@teh-cmc teh-cmc self-requested a review December 15, 2023 07:32
@emilk emilk merged commit 32a468c into main Dec 15, 2023
40 checks passed
@emilk emilk deleted the emilk/smaller-examples branch December 15, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc