Replace some of our use of polars
#4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
dependencies
emilk
force-pushed
the
emilk/replace-polars
branch
from
b0e94e0
to
99f09de
Compare
emilk
commented
Jan 12, 2024
| _ = _store.to_dataframe(); // simple way of checking that everything is still readable | ||
| } | ||
| fn check_still_readable(store: &DataStore) { | ||
| store.to_data_table().unwrap(); // simple way of checking that everything is still readable |
There was a problem hiding this comment.
I'm not 100% sure what the comment means by "readable"
There was a problem hiding this comment.
It's a simple sanity check that it is still possible to iterate through the entire store and get all the data out in a table.
Pretty basic but has failed quite a few times 😇
emilk
commented
Jan 12, 2024
Comment on lines
+142
to
+147
| { | ||
| // We use a RowSet instead of a DataTable to handle duplicate RowIds. | ||
| let mut row_set = RowSet::default(); | ||
| row_set.insert_tables(store1.to_data_tables(None)); | ||
| row_set.insert_into(store2); | ||
| sanity_unwrap(store2); |
There was a problem hiding this comment.
The old code would use "retrying" to generate new row-ids, which mean the resulting DataTables weren't the same anymore, hence the new RowSet test struct.
The old test worked because to_dataframe ignored rowids
teh-cmc
approved these changes
Jan 15, 2024
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
arrow2and get rid ofpolars#4789We're using polars for some tests.
This PR replaces polars with our own data tables for the tests.
https://github.com/rerun-io/rerun/blob/main/crates/re_data_store/tests/data_store.rs is left, and a pain in the ass.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io