Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-selection drag-and-drop demos #4879

Merged
merged 37 commits into from
Jan 25, 2024
Merged

Single-selection drag-and-drop demos #4879

merged 37 commits into from
Jan 25, 2024

Commits on Jan 19, 2024

  1. WIP: basics work but selection is wacky 

    TODO
- figure out weird selection behaviour
- `ui.interact()` kills ListItem over -> migrate to `ListItem`
- clean logic code
    @abey79
    abey79 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3a08110 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. WIP: fix selection behaviour 

    TODO
- `ui.interact()` kills ListItem over -> migrate to `ListItem`
- clean logic code
    @abey79
    abey79 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d3af316 View commit details
    Browse the repository at this point in the history

  2. Drag support in ListItem + code cleanup

    @abey79
    abey79 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    154bd0f View commit details
    Browse the repository at this point in the history

  3. Lint

    @abey79
    abey79 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    81ff675 View commit details
    Browse the repository at this point in the history

  4. Lint + moved code to a better place

    @abey79
    abey79 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ed6e2c3 View commit details
    Browse the repository at this point in the history

  5. Added hierarchical version of the demo

    @abey79
    abey79 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9dd1cbb View commit details
    Browse the repository at this point in the history

  6. Lint

    @abey79
    abey79 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f689bf6 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. WIP

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f863c3d View commit details
    Browse the repository at this point in the history

  2. WIP - hierarchy dnd feature complete / TODO: clean code

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d9841e6 View commit details
    Browse the repository at this point in the history

  3. Much improved hierachical drag and drop

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b5f0e0b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into antoine/dnd_demo

    @abey79
    abey79 authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8598e35 View commit details
    Browse the repository at this point in the history

  5. Fixed bug and improved code

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a168a5b View commit details
    Browse the repository at this point in the history

  6. ASCII art!! ٩(๑･ิᴗ･ิ)۶

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5eec3ab View commit details
    Browse the repository at this point in the history

  7. Highlight destination container

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c902974 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into antoine/dnd_demo

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    39c173d View commit details
    Browse the repository at this point in the history

  9. Review comment: non-hierarchial demo in mod + better item id

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b0cbd00 View commit details
    Browse the repository at this point in the history

  10. Review comment: hierarchical demo in mod

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a283f75 View commit details
    Browse the repository at this point in the history

  11. Review comment: DragTarget -> DropTarget

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2177577 View commit details
    Browse the repository at this point in the history

  12. Review comment: X before Y

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c220dd0 View commit details
    Browse the repository at this point in the history

  13. Review comment: better note on adding response.drag_stopped()

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a1faa50 View commit details
    Browse the repository at this point in the history

  14. Review comment: cursor -> drag target indicator

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f8f6c62 View commit details
    Browse the repository at this point in the history

  15. Removed one todo that could be cleaned up + lint

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e14f9cf View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into antoine/dnd_demo 

    # Conflicts:
#	Cargo.lock
    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    69aa6db View commit details
    Browse the repository at this point in the history

  17. Post merge fix

    @abey79
    abey79 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f8357b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Update crates/re_ui/examples/re_ui_example.rs 

    Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
    @abey79 @emilk
    abey79 and emilk authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fd3251e View commit details
    Browse the repository at this point in the history

  2. Review comment: set cursor to Grabbing

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0d519aa View commit details
    Browse the repository at this point in the history

  3. Review comment: ListItem::drag_id -> draggable

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    1b6257b View commit details
    Browse the repository at this point in the history

  4. Review comment: pos -> position_idx

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4659239 View commit details
    Browse the repository at this point in the history

  5. Review comment: misc

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6d90d4d View commit details
    Browse the repository at this point in the history

  6. Update to latest egui commit and removed some TODOs

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    ab2cdc6 View commit details
    Browse the repository at this point in the history

  7. Review comment: updated TODOs

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    069b894 View commit details
    Browse the repository at this point in the history

  8. Review comment: ListItem::drag_target -> drop_target_style

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e7e21f2 View commit details
    Browse the repository at this point in the history

  9. Review comment: removed item string from the flat demo

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0c4a69b View commit details
    Browse the repository at this point in the history

  10. Review comment: clarified MoveItem command + moar cleanup

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6d29e79 View commit details
    Browse the repository at this point in the history

  11. Review comment: moved the DnD demo to be better separated from the ot… 

    …her demos
    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d145e73 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into antoine/dnd_demo

    @abey79
    abey79 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    755927b View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Merge branch 'main' into antoine/dnd_demo

    @abey79
    abey79 authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    94b9a81 View commit details
    Browse the repository at this point in the history