Update to latest egui, with added error handling in eframe #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will lead to `Err` and python exceptions instead of panics for users for which we cannot initialize a rendering context (or at least for some of them).
jleibs
approved these changes
Dec 12, 2022
| @@ -1,7 +1,7 @@ | |||
| use re_log_types::LogMsg; | |||
|
|
|||
| #[cfg(feature = "re_viewer")] | |||
| pub fn show(log_messages: Vec<LogMsg>) { | |||
| pub fn show(log_messages: Vec<LogMsg>) -> eframe::Result<()> { | |||
There was a problem hiding this comment.
I was a bit surprised to see an eframe::Result leak out of the SDK. Seems like we should potentially be introducing a rerun_sdk error type.
There was a problem hiding this comment.
yeah, I was a bit hesitant here too. We should probably wrap it in our own type, but this is an ok start imho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related egui PR: emilk/egui#2433
This will lead to
Errand python exceptions instead of panics for users for which we cannot initialize a rendering context (or at least for some of them).The update also includes some improved logging during shutdown (at
debuglog level) and some minor tweaks.Checklist
CHANGELOG.md(if this is a big enough change to warrant it)