Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified visualizer & override ui, enabled on all entities #6599

Merged
merged 11 commits into from
Jun 20, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 19, 2024

What

Previously, we had ui for adding component overrides, under an experimental feature everywhere except the time series view + some hardcoded ui for manipulating overrides (those that were EntityProperties in 0.16).

This PR removes both the component override ui and the hardcoded property ui in favor of a new overview + override ui showing all currently used values by all active visualizers + ability to add/remove visualizers.

Recording.2024-06-19.163825.mp4

Noteworthy "sideeffects":

  • ComponentUiCallback now uses raw arrow arrays, allowing it to show fallbacks
  • kills lots'a old code :)
  • VisualizerQueryInfo::queried keeps now archetype component ordering instead of alphabetical (not in above video yet)
  • lots of inconsistency in our data flow are now visible

Planned direct follow-ups:

  • allow various reset / override menus
  • allow expanding to see the override/store/default/fallback stack
    • original plan was to skip on this, but the method has all the data layed out neatly now, so might as well!
  • get the "Add" button integrated into the top (unless this is hard?)
  • show better docs: Improve tooltips for overrides and defaults as well as for enums  #6556
  • Find a better name for the "blueprint section" below

Also needed but not planned short term:

  • inspect multivalues
    • we could do so for store multivalues already, but everything else we can't yet select, so let's tackle this later
  • ui polish

Part of:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Jun 19, 2024
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a nice improvement!

crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 4b6bc9e into main Jun 20, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the andreas/visualizer-ui branch June 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants