Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixi: Add missing feature "cpp" to "wheel-test" environment #6845

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jul 10, 2024

What

Should fix red main.

The cpp feature was missing from the wheels-test environment.

Since the “cpp” feature is now part of both the “cpp” environment and the “wheel-test” environment, we have to disambiguate with -e cpp

Checklist

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jul 10, 2024
@emilk
Copy link
Member Author

emilk commented Jul 10, 2024

@rerun-bot full-check

Copy link

github-actions bot commented Jul 10, 2024

Deployed docs

Commit Link
4dbf1de https://landing-ka815is2z-rerun.vercel.app/docs

Copy link

@emilk
Copy link
Member Author

emilk commented Jul 10, 2024

@rerun-bot full-check

Copy link

@emilk
Copy link
Member Author

emilk commented Jul 10, 2024

I'm merging this in the interest of unblocking other PRs and making main green again

@emilk emilk merged commit b277376 into main Jul 10, 2024
74 of 75 checks passed
@emilk emilk deleted the emilk/pixi-fix branch July 10, 2024 09:50
@jleibs
Copy link
Member

jleibs commented Jul 10, 2024

Can you explain why wheel-test needs a dep on the cpp feature? What was the problem that this was trying to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants