Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Revamp TestUtils & tests #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bloodyowl
Copy link
Contributor

@bloodyowl bloodyowl commented Mar 10, 2021

→ Removes Jest
→ Updates peerDependencies

Test files render

Setup

Screen Shot 2021-03-10 at 13 44 34

Assertions setup

Screen Shot 2021-03-10 at 13 45 02

Tests

Screen Shot 2021-03-10 at 13 43 21

Screen Shot 2021-03-10 at 13 43 44

Test output render

Screen Shot 2021-03-10 at 16 55 09

Screen Shot 2021-03-10 at 16 55 58

Copy link

@JasoonS JasoonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me (although I have zero authority here...)

@cknitt
Copy link
Member

cknitt commented Sep 30, 2022

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

@cristianoc
Copy link
Contributor

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

Not sure. Do they add value to justify the maintenance? E.g w.r.t. snapshot test where one just looks at the generated code?

Could go either way. No opinion.

@mununki
Copy link
Member

mununki commented Oct 4, 2022

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

@cristianoc
Copy link
Contributor

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

Checking in che compiled output seems by far the easiest thing. And tells everything there is to know.

@@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x]
node-version: [14.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add 16 since it's the current LTS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants