Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document symbols broken (flat) from v1.9.25 #654

Closed
cristianoc opened this issue Dec 15, 2022 · 4 comments · Fixed by #655
Closed

Document symbols broken (flat) from v1.9.25 #654

cristianoc opened this issue Dec 15, 2022 · 4 comments · Fixed by #655

Comments

@cristianoc
Copy link
Collaborator

From version 1.9.25 the symbols in the document appear as a flat list and not nested.
@cristianoc
Copy link
Collaborator Author

In 1.9.24:

Screenshot 2022-12-15 at 17 48 03

In 1.9.25:

Screenshot 2022-12-15 at 17 47 14

@cristianoc
Copy link
Collaborator Author

@aspeddro would you take a look?
I think it's after thing change: #629
Not sure how things are expected to be represented in order do communicate the nesting of elements.

@aspeddro
Copy link
Contributor

I'm looking at this.

cristianoc added a commit that referenced this issue Dec 16, 2022
@cristianoc
Emit nested document symbols.
d3a3d9a 
Fixes #654.

The change in #629 moved to a non-deprecated representation of document symbol.
The new representation is the "Ikea" version of the old one, where children symbol are not computed for you, but need to be provided.
This PR computes and emits the tree of symbols using the `children` field.
@cristianoc cristianoc mentioned this issue Dec 16, 2022
Merged
@cristianoc
Copy link
Collaborator Author

Turns out a bunch of extra work is required now: #655

cristianoc added a commit that referenced this issue Dec 17, 2022
@cristianoc
Emit nested document symbols. (#655)
688a6ca 
* Emit nested document symbols.

Fixes #654.

The change in #629 moved to a non-deprecated representation of document symbol.
The new representation is the "Ikea" version of the old one, where children symbol are not computed for you, but need to be provided.
This PR computes and emits the tree of symbols using the `children` field.

* indent

* Refactor code for indentation.

* Update CHANGELOG.md

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit nested document symbols. rescript-lang/rescript-vscode
2 participants
@cristianoc @aspeddro