Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with logging not in debug mode. #575

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Fix issue with logging not in debug mode. #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daf7f90
Fix issue with logging not in debug mode.
cristianoc Sep 5, 2022
c04eb6d
Update CHANGELOG.md
cristianoc Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

#### :bug: Bug Fix

- Fix issue where debug output would end up in the JSON file produced by Reanalyze https://github.com/rescript-lang/rescript-vscode/pull/575
- Fix issue where autocomplete would not perform type instantiation https://github.com/rescript-lang/rescript-vscode/pull/561
- Fix issue where hovering over a field in record construction would show the type without instantiating its type arguments https://github.com/rescript-lang/rescript-vscode/pull/560
- Fix Incorrect semantic highlighting of `external` declarations https://github.com/rescript-lang/rescript-vscode/pull/517
Expand Down
5 changes: 3 additions & 2 deletions analysis/reanalyze/src/Paths.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ let readSourceDirs ~configSources =
else readDirs json
| None -> ()
else (
Log_.item "Warning: can't find source dirs: %s\n" sourceDirs;
Log_.item "Types for cross-references will not be found by genType.\n";
if !Cli.debug then (
Log_.item "Warning: can't find source dirs: %s\n" sourceDirs;
Log_.item "Types for cross-references will not be found.\n");
dirs := readDirsFromConfig ~configSources);
!dirs