Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial pattern completion #670

Merged
merged 31 commits into from
Jan 5, 2023
Merged

Initial pattern completion #670

merged 31 commits into from
Jan 5, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 1, 2023

This isn't complete yet, but I want to validate the approach with you @cristianoc before I continue deeper. This PR does the following:

  • Introduces the concept of pattern completion
  • Adds logic for tracking what type we're at in the current pattern. Currently handles tuples and record fields, but will eventually handle everything that can appear in a pattern (like variant/polyvariant constructors + payloads, options, array literals, etc)

@zth zth requested a review from cristianoc January 1, 2023 09:47
cristianoc
cristianoc reviewed Jan 1, 2023
View reviewed changes
analysis/src/CompletionFrontEnd.ml Outdated Show resolved Hide resolved
analysis/src/CompletionFrontEnd.ml Outdated Show resolved Hide resolved
@zth zth mentioned this pull request Jan 3, 2023
Open
24 tasks
zth added 25 commits January 4, 2023 21:07
@zth
basic setup of some sort of structure, and complete tuple patterns
9a63a84
@zth
nested tuple
112ee62
@zth
start integrating completion for records
c18e7bf
@zth
complete record bodies/fields in patterns
352872f
@zth
handle completing for new record fields, and filtering already seen f…
01516a6 
…ields
@zth
add test for patterns under other patterns, and handle unsetting what…
5f4d7e0 
… pattern we're currently looking for
@zth
identify and handle completing destructuring patterns
3c7562c
@zth
comments and cleanup
cc8412f
@zth
add nested destructure test
4df242f
@zth
fix
26b0e68
@zth
descend through variant payloads
779e1be
@zth
handle polyvariants
d349f43
@zth
complete arrays in patterns
72039e2
@zth
handle multiple payloads in variants/polyvariants via regular tuple h…
57ba325 
…andling
@zth
move from ast iterator to traversal function for finding completables…
3eb59e2 
… in patterns
@zth
ignore unused var
8e3baf5
@zth
handle options
dda7fd4
@zth
handle completing new items in constructor/variant payloads with mult…
3ea5168 
…iple items
@zth
handle completing new items in tuples
124509e
@zth
add broken parser case
68e22db
@zth
remove unused
23b7833
@zth
refactor and unify how pat tuple items are traversed
5976234
@zth
simplify setting completion pattern
c601823
@zth
handle completing root switch case when theres more than one case
a828e79
@zth
refactor
11cb6ae
@zth zth force-pushed the pattern-completion branch from fdcf9b1 to a61f06b Compare January 4, 2023 20:07
cristianoc
cristianoc approved these changes Jan 5, 2023
View reviewed changes
analysis/src/CompletionFrontEnd.ml Outdated Show resolved Hide resolved
@zth zth merged commit dbd0f69 into master Jan 5, 2023
@zth zth deleted the pattern-completion branch January 5, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc