Let ppat_any trigger completion in patterns #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Jan 12, 2023
analysis/src/CompletionFrontEnd.ml
Outdated
| @@ -695,6 +695,7 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor ~text = | |||
| match orPatWithItem with | |||
| | None when isPatternHole p1 || isPatternHole p2 -> Some ("", patternPath) | |||
| | v -> v) | |||
| | Ppat_any -> someIfHasCursor ("", patternPath) | |||
There was a problem hiding this comment.
Perhaps add a quick comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that triggering completion on
_(Ppat_any) is considered the same as triggering an empty typed completion.Some(<com>)andSome(_<com>)is now considered the same when triggering completion.The main reason is that we're inserting
_and putting the cursor on it via snippets. So, being able to trigger completion directly again on_is quite helpful.