support completing in/through inline records in variant payloads #695
Conversation
| let extractedType = | ||
| match t with | ||
| | TypeExpr t -> t |> extractType ~env ~package:full.package | ||
| | InlineRecord fields -> Some (TinlineRecord {env; fields}) |
There was a problem hiding this comment.
I was a wondering why we need a variant called InlineRecord in two places in SharedTypes.
I guess the question can be rephrased here as: do we need TypeExpr and InlineRecord to exist at the same level here? Somehow an inline record is not a self-standing type.
Not sure I have something concrete to suggest, just an open-ended question.
There was a problem hiding this comment.
It's a good question for sure, and I don't have a clear/good answer either. One extra bit of context is that I intend to add another constructor there as well soon, for handling completing from Type.t (via type annotations for example).
I guess I view this as the "type source" to derive what to complete from, and this was the fastest/easiest way to handle inline records since they have no type expression of their own. And I guess the same will be true for types derived from type annotations?
There was a problem hiding this comment.
Let's come back to this eventually. I'll merge now so I can move on to the next thing.
No description provided.