special handling of optional fields when destructuring #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Jan 26, 2023
analysis/src/CompletionBackEnd.ml
Outdated
| @@ -1047,10 +1047,10 @@ let printConstructorArgs argsLen ~asSnippet = | |||
| if List.length !args > 0 then "(" ^ (!args |> String.concat ", ") ^ ")" | |||
| else "" | |||
|
|
|||
| type completionMode = Pattern | Expression | |||
| type completionMode = Pattern of Completable.patternMode option | Expression | |||
There was a problem hiding this comment.
I am wondering if we can get rid of the option here by having
type patternMode = Default | Destructuringor something like that?
cristianoc
reviewed
Jan 26, 2023
|
Right now it's configured to only affect let destructures. |
cristianoc
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #714
cc @cknitt