Complete lowercase JSX elements #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Feb 1, 2023
| let htmlElements = | ||
| [ | ||
| ("a", "Defines a hyperlink.", false); | ||
| ("abbr", "Defines an abbreviated form of a longer word or phrase.", false); |
There was a problem hiding this comment.
How does this compare with the complete list currently supported? A subset? (E.g. aria).
There was a problem hiding this comment.
Hmmm, not sure I follow what you mean..?
There was a problem hiding this comment.
I guess this is a selection of all the possible ones accepted by the type checker.
There was a problem hiding this comment.
No I think the type checker would accept anything, I think the JSX tag name is just turned into a string by the PPX. So this is strictly about providing completion/information for something that we don't really have (or care) about type information for right now. So it's strictly an addon/extra help.
zth
force-pushed
the
complete-lowercase-jsx-elements
branch
from
53b0513 to
4428d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds completion for lowercase JSX elements, treating them like HTML elements.
Potential follow up for this - there's a heuristic in the hover mechanism that detects lowercase elements. Maybe we should leverage this new list of elements and descriptions in there too? It currently shows some fairly irrelevant things.