Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent broken locs from being added to document symbols #736

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Feb 27, 2023

Closes #735

@cristianoc problem was that broken code like this:

type observer = {next:}

...would produce a document symbol entry looking like this:
children Array(1))

Notice character: -1 in end.

Is the checking I'm doing unnecessarily much? I also found no good way to add tests for this since it's only happening in broken syntax.

@zth zth requested a review from cristianoc February 27, 2023 19:49
@zth zth marked this pull request as ready for review February 27, 2023 19:49
@zth zth merged commit da0841c into master Feb 27, 2023
@zth zth deleted the fix-document-symbol-crash branch February 27, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant error popups - "Request textDocument/documentSymbol failed."
2 participants