prettify optional fields in completion detail #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Feb 28, 2023
| (* Handle optional fields. Checking for "?" is because sometimes optional | ||
| fields are prefixed with "?" when completing, and at that point we don't | ||
| need to _also_ add a "?" after the field name, as that looks weird. *) | ||
| if optional && Utils.startsWith name "?" = false then |
There was a problem hiding this comment.
nit: little code duplication in the if and else branch, perhaps better to unify, perhaps not
There was a problem hiding this comment.
I was being goal oriented 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prettifies how optional fields are printed in the completion detail.
Before:
After: