Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL scheme for code actions #748

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Mar 10, 2023

Neovim client raise an error because server does not return an URI scheme file:///

Error executing vim.schedule lua callback: /usr/share/nvim/runtime/lua/vim/uri.lua:107: URI must contain a scheme: /home/pedro/Desktop/learning-rescript/src/let_binding.res
stack traceback:
        [C]: in function 'assert'
        /usr/share/nvim/runtime/lua/vim/uri.lua:107: in function 'uri_to_fname'
        /usr/share/nvim/runtime/lua/vim/uri.lua:128: in function 'uri_to_bufnr'
        /usr/share/nvim/runtime/lua/vim/lsp/util.lua:570: in function 'apply_text_document_edit'
        /usr/share/nvim/runtime/lua/vim/lsp/util.lua:828: in function 'apply_workspace_edit'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:803: in function 'apply_action'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:857: in function 'on_choice'
        /usr/share/nvim/runtime/lua/vim/ui.lua:54: in function 'select'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:868: in function 'on_code_action_results'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:886: in function 'callback'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1952: in function 'handler'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1383: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

@zth
Copy link
Collaborator

zth commented Apr 27, 2023

@aspeddro did you test this in VSCode as well?

@aspeddro
Copy link
Contributor Author

Yes, everything working.

@zth zth self-requested a review April 27, 2023 19:33
@zth
Copy link
Collaborator

zth commented Apr 27, 2023

Looks like there's still conflicts. Happy to merge after they're fixed.

@aspeddro
Copy link
Contributor Author

Conflicts resolved.

@zth zth merged commit fc1aeb1 into rescript-lang:master Apr 27, 2023
@aspeddro aspeddro deleted the fix-code-action-url-scheme branch October 12, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants