Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting for raw JS code #774

Merged
merged 3 commits into from
May 24, 2023

Conversation

fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented May 23, 2023

@fhammerschmidt
Copy link
Member Author

Note: I did not implement it for "" strings, because I think that would break too easily.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mind adding to the changelog?

@cristianoc
Copy link
Collaborator

cristianoc commented May 23, 2023

Actually would you do it for %ffi?
Notice single %

@zth
Copy link
Collaborator

zth commented May 23, 2023

Actually would you do it for %ffi? Notice single %

Judging from the screenshot this already works, no?

@cristianoc
Copy link
Collaborator

Actually would you do it for %ffi? Notice single %

Judging from the screenshot this already works, no?

Oh right I did not see the second one.

@fhammerschmidt
Copy link
Member Author

fhammerschmidt commented May 23, 2023

It works for %raw, %%raw and %ffi. And technically also for the non-existent %%ffi, but that should not be an issue, is it?

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks!

grammars/rescript.tmLanguage.json Outdated Show resolved Hide resolved
@fhammerschmidt fhammerschmidt requested review from cristianoc and zth May 24, 2023 06:29
@cristianoc cristianoc merged commit 3d1591d into rescript-lang:master May 24, 2023
@fhammerschmidt fhammerschmidt deleted the ffi-highlighting branch May 24, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants