Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make function template async when fn returns a promise #816

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Make function template async when fn returns a promise #816

merged 2 commits into from
Sep 11, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 11, 2023

Small quality of life improvement - when a function returns a promise, make the suggested function template async.

@zth zth requested a review from cristianoc September 11, 2023 11:01
cristianoc
cristianoc approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch

@zth zth merged commit f549132 into master Sep 11, 2023
4 checks passed
@zth zth deleted the async-fn-template branch September 11, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc