Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for pipes in completion of single unlabelled argument #818

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 11, 2023

Another quality-of-life thing. Previously, this: someArray->Array.map(<com> would ignore the pipe and complete as the first argument to Array.map, which would be the array itself, rendering a [] suggestion. With this change we instead get a function template suggested, like v => {}.

Next level on this would be to track the path/name of Array.map and change the suggested variable name in the function template to something nicer than the generic v, like item.

@zth zth requested a review from cristianoc September 11, 2023 11:30
@zth zth merged commit ec59c6a into master Sep 11, 2023
5 checks passed
@zth zth deleted the pipe-in-unlabelled-completion branch September 11, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants