-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rescript/tools
to OCaml
#855
Conversation
I really like this approach. (Haven't tried this branch.) These changes would have removed lots of friction for me, getting started. 👍 |
Good to know @woeps. Another point this brings is to decouple The situation is that with each new resource, the transition in the future becomes more difficult. |
@zth If you are interested I can resolve the conflicts |
@aspeddro let's do it! |
@aspeddro sorry, another merge needed... 😬 I tried the branch and it seems to work! I wasn't able to get ocamlformat working though (but I didn't try that much, just noticed it's broken for me). Do you have it working? |
rescript/tools
to OCaml Code,tools/src/Cli.res
totools/bin/main.ml
analysis
is a library consumed bytools
. Therescript-editor-analysis
binary is still built, seeanalysis/bin/main.ml
Ideally, we should divide packages by platform (rescript-lang/rescript#6183), but this change seeks to reduce node bin wrapper
Everything works as a monorepo:
dune build
compileanalysis
andtools
.analysis
is a dep oftools
.analysis
directoryI think this improves the development experience.