Do not crash entire extension when analysis fails #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Jan 7, 2024
|
Yeah this now shows some information around what crashed. Still quite bare bones, but more than before. |
… error as a message but only every 15 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead report the error as a message, but only every 15 minutes.
We want people to report when things crash, but having the entire extension crash because of some potentially minor thing (code actions failing to resolve for example) is a bad experience. This makes sure that the extension does not crash when the analysis fails, but rather reports a message with the error (and not too often).
This is a good balance imo between getting people to report and preserving the UX of the extension.