Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSX prop autocomplete special case #984

Merged
merged 2 commits into from
May 25, 2024
Merged

Fix JSX prop autocomplete special case #984

merged 2 commits into from
May 25, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented May 25, 2024

Fixes #962

@zth zth requested a review from cristianoc May 25, 2024 09:47
cristianoc
cristianoc approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@zth zth merged commit 2d8d942 into master May 25, 2024
6 checks passed
@zth zth deleted the fix-incorrect-autocomplete-for-jsx-props-after-variant branch May 25, 2024 10:07
jfrolich pushed a commit to jfrolich/rescript-vscode that referenced this pull request Sep 3, 2024
@zth @jfrolich
Fix JSX prop autocomplete special case (rescript-lang#984)
2b2a937 
* ensure there is an equal sign present when triggering special cased JSX prop completion

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect autocomplete for jsx props after a variant
2 participants
@zth @cristianoc