Code actions for removing dead code #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem, driven by reanalyze
zth
commented
May 27, 2024
cristianoc
approved these changes
May 27, 2024
|
Removing types is much more involved, and unclear how to do automatically. E.g. one variant case. |
jfrolich
pushed a commit
to jfrolich/rescript-vscode
that referenced
this pull request
Sep 3, 2024
* code actions for removing dead code in the current file + each dead item, driven by reanalyze * changelog and cleanup * comment and extra match * comment, and handle another case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later on it'd be nice to have a command to run that can remove all of the dead code in a project. This might be better to do in
reanalyzeitself though? Or we can have an action in the editor that uses the editor to apply the edits. That would be easy to do as a first step. Although it'd only work in VSCode at first.