fix: issuesreported in sonar cloud

content/visualisation/2021-08-04-Which-Statistical-Test-To-Use-For-Two-Variables/flowChart/flowChart.jsx

@@ -69,7 +69,7 @@ const connectionLineStyle = { stroke: "#fff" };
  * Return flowchart
  * @returns
  *************************/
-const flowChart = () => {
+const FlowChart = () => {
   const [displayChart, setDisplayChart] = useState(false);
   const [showAll, toggleShowAll] = useState(false);
   const [centreOnClick, toggleCentre] = useState(true);
@@ -629,4 +629,4 @@ const flowChart = () => {
   );
 };
 
-export default flowChart;
+export default FlowChart;

content/visualisation/2022-01-31-ORDA-datasets-FAIRness-assessment/components/datasetSummary.jsx

@@ -182,7 +182,7 @@ const DatasetSummary = ({ currentDataset }) => {
   };
 
   if (loading) {
-    <div>Loading...</div>;
+    return <div>Loading...</div>;
   }
 
   return (

gatsby-node.js

@@ -332,7 +332,7 @@ exports.createPages = async ({ graphql, actions, reporter }) => {
   });
 
   const POSTS_PER_PAGE = 12;
-  var numPages = posts.length;
+  let numPages = posts.length;
   const categories = [];
   const tags = [];
 
@@ -341,7 +341,7 @@ exports.createPages = async ({ graphql, actions, reporter }) => {
 
   // Call `createPage` for each result/post
   posts.forEach(({ node }, index, arr) => {
-    var excluded = false;
+    let excluded = false;
 
     // For each post, add their tags/categories to arrays
     node.frontmatter.category &&

src/components/blog/menuTag.jsx

@@ -6,10 +6,10 @@ import { FaTags, FaAngleDown } from "react-icons/fa";
 import { FiSearch } from "react-icons/fi";
 import { useLocation } from "@gatsbyjs/reach-router";
 
-const menuTag = ({ pageContext, handleTagMenu, tagMenu }) => {
+const MenuTag = ({ pageContext, handleTagMenu, tagMenu }) => {
   const [filterTag, setfilterTag] = useState(pageContext.allTags);
 
-  var { href } = useLocation();
+  let { href } = useLocation();
   if (!href) href = "";
 
   function searchTag(e) {
@@ -86,8 +86,10 @@ const menuTag = ({ pageContext, handleTagMenu, tagMenu }) => {
   );
 };
 
-export default menuTag;
+export default MenuTag;
 
-menuTag.propTypes = {
-  pageContext: PropTypes.any
+MenuTag.propTypes = {
+  pageContext: PropTypes.any,
+  handleTagMenu: PropTypes.func,
+  tagMenu: PropTypes.bool
 };

src/components/blog/menuTagSlide.jsx

@@ -7,10 +7,10 @@ import { FiSearch } from "react-icons/fi";
 import { IoMdClose } from "react-icons/io";
 import { useLocation } from "@gatsbyjs/reach-router";
 
-const menuTagSlide = ({ pageContext, handleTagMenu, tagMenu }) => {
+const MenuTagSlide = ({ pageContext, handleTagMenu, tagMenu }) => {
   const BUTTON_STYLES = `bg-brand-blue text-brand-black hover:bg-brand-black hover:text-white`;
   const [filterTag, setfilterTag] = useState(pageContext.allTags);
-  var { href } = useLocation();
+  let { href } = useLocation();
   if (!href) href = "";
 
   function handleChange(e) {
@@ -61,7 +61,9 @@ const menuTagSlide = ({ pageContext, handleTagMenu, tagMenu }) => {
         title="Close the menu"
         aria-label="Close the slide tag menu"
       >
-        <div className={`${BUTTON_STYLES} px-3 py-3 transition duration-500 font-bold`}>
+        <div
+          className={`${BUTTON_STYLES} px-3 py-3 transition duration-500 font-bold`}
+        >
           <IoMdClose />
         </div>
       </button>
@@ -117,8 +119,10 @@ const menuTagSlide = ({ pageContext, handleTagMenu, tagMenu }) => {
   );
 };
 
-export default menuTagSlide;
+export default MenuTagSlide;
 
-menuTagSlide.propTypes = {
-  pageContext: PropTypes.any
+MenuTagSlide.propTypes = {
+  pageContext: PropTypes.any,
+  handleTagMenu: PropTypes.func,
+  tagMenu: PropTypes.bool
 };

src/components/blog/postPagination.jsx

@@ -22,7 +22,7 @@ class PostPagination extends React.Component {
     const displayShareButtons = this.props.displayShareButtons ?? true;
     const { githubLink, shareLink, shareMessage } = shareLinks;
 
-    var mdxType = mdx.frontmatter.type || "blog";
+    let mdxType = mdx.frontmatter.type || "blog";
 
     let prevTitle = prev ? shortenText(prev.node.frontmatter.title, 6) : "";
     let nextTitle = next ? shortenText(next.node.frontmatter.title, 6) : "";

src/components/home/eventNotice.jsx

@@ -6,7 +6,7 @@ import Fade from "react-reveal/Fade";
 import { shortenText, calculateUserLocalTime } from "../../utils/shared";
 import NoThumb from "../../images/no_thumbnail.png";
 
-const eventNotice = ({ eventBrite }) => {
+const EventNotice = ({ eventBrite }) => {
   const UPDATE_TIME_MS = 30000;
   const [currentDate, setDate] = useState(
     moment().format("ddd DD MMMM YYYY, hh:mm A")
@@ -114,8 +114,8 @@ const eventNotice = ({ eventBrite }) => {
   );
 };
 
-export default eventNotice;
+export default EventNotice;
 
-eventNotice.propTypes = {
+EventNotice.propTypes = {
   eventBrite: PropTypes.any
 };

src/components/home/latestPost.jsx

@@ -9,7 +9,7 @@ import { getImageSource, shortenText } from "../../utils/shared";
 import { GatsbyImage } from "gatsby-plugin-image";
 
 const latestPost = ({ post }) => {
-  var count = 0;
+  let count = 0;
 
   return (
     <>

src/components/home/searchHome.jsx

@@ -206,12 +206,12 @@ class SearchHome extends Component {
   }
 
   getSearchResults(query) {
-    var index = window.__FLEXSEARCH__.en.index;
-    var store = window.__FLEXSEARCH__.en.store;
+    let index = window.__FLEXSEARCH__.en.index;
+    let store = window.__FLEXSEARCH__.en.store;
     if (!query || !index) {
       return [];
     } else {
-      var results = [];
+      let results = [];
       // search the indexed fields
       Object.keys(index).forEach((idx) => {
         results.push(...index[idx].values.search(query)); // more search options at https://github.com/nextapps-de/flexsearch#index.search

src/components/shared/header.jsx

@@ -13,14 +13,15 @@ const Header = () => {
   const [isScroll, toggleScrolled] = useState(false);
   const [isOpen, toggleOpen] = useState(false);
   const location = useLocation();
-  var currentPagePath = location.pathname;
+  let currentPagePath = location.pathname;
 
   // close mobile menu on route change
-  if (typeof window !== "undefined" && window.screen.width <= 1200) {
-    useEffect(() => {
+  useEffect(() => {
+    if (typeof window !== "undefined" && window.screen.width <= 1200) {
       toggleExpansion(false);
-    }, [location]);
-  }
+    }
+    toggleExpansion(false);
+  }, [location]);
 
   // monitor page scroll
   useEffect(() => {
@@ -99,7 +100,7 @@ const Header = () => {
    */
   const NavLink = (props) => {
     function navColourClass(mobile = false) {
-      var className = "transition duration-300 relative "; // don't remove space
+      let className = "transition duration-300 relative "; // don't remove space
 
       if (mobile == "true") {
         if (isScroll) {
@@ -176,7 +177,7 @@ const Header = () => {
   };
 
   function mobileMenuIconClass() {
-    var className =
+    let className =
       "px-3 py-2 flex items-center border rounded outline-none transition duration-300 group-hover:border-gray-700 group-hover:text-gray-700";
 
     if (isExpanded || isScroll || currentPagePath === "/") {
@@ -189,7 +190,7 @@ const Header = () => {
 
   function copyRssLink() {
     toggleOpen(true);
-    var copyText = document.querySelector("#rssLink");
+    let copyText = document.querySelector("#rssLink");
     copyText.select();
     copyText.setSelectionRange(0, 9999);
     document.execCommand("copy");

src/components/shared/scrollTop.jsx

@@ -1,22 +1,24 @@
-import React from 'react'
-import PropTypes from "prop-types"
-import { IoIosArrowUp } from "react-icons/io"
-import { trackScrollPosition } from "../../utils/hooks/trackScrollPosition"
+import React from "react";
+import PropTypes from "prop-types";
+import { IoIosArrowUp } from "react-icons/io";
+import { useTrackScrollPosition } from "../../utils/hooks/trackScrollPosition";
 
 const scrollTop = () => {
-
-  trackScrollPosition("scrollTop-btn");
+  useTrackScrollPosition("scrollTop-btn");
 
   return (
-    <div id="scrollTop-btn" className="scrollTop-btn cursor-pointer group" onClick={() => window.scrollTo({ top: 0, behavior: 'smooth' })}>
-        <IoIosArrowUp className="scrollTopArrow absolute font-bold text-3xl text-gray-500 group-hover:text-white" />
+    <div
+      id="scrollTop-btn"
+      className="scrollTop-btn cursor-pointer group"
+      onClick={() => window.scrollTo({ top: 0, behavior: "smooth" })}
+    >
+      <IoIosArrowUp className="scrollTopArrow absolute font-bold text-3xl text-gray-500 group-hover:text-white" />
     </div>
-  )
-}
+  );
+};
 
-export default scrollTop
+export default scrollTop;
 
 scrollTop.propTypes = {
-  pageContext: PropTypes.any,
-
-}
+  pageContext: PropTypes.any
+};

src/components/shared/search.jsx

@@ -20,8 +20,8 @@ class Search extends Component {
   componentDidMount = () => {
     setTimeout(() => {
       if (this.props.location.state && this.props.location.state.searchWord) {
-        var queryHome = this.props.location.state.searchWord;
-        var input = document.getElementById("pageSearch");
+        let queryHome = this.props.location.state.searchWord;
+        let input = document.getElementById("pageSearch");
         this.setState({ query: queryHome });
         input.setAttribute("value", queryHome);
         this.searchFunction(queryHome);
@@ -31,34 +31,30 @@ class Search extends Component {
 
   render() {
     const ResultList = () => {
-      // query length changed from 2 to 0
-      if (this.state.results.length > 0 && this.state.query.length > 0) {
-        const data = useStaticQuery(graphql`
-          query postList {
-            allMdx(
-              sort: { fields: [frontmatter___date], order: DESC }
-              filter: { frontmatter: { published: { ne: false } } }
-            ) {
-              edges {
-                node {
-                  id
-                  frontmatter {
-                    date(formatString: "ddd, DD MMM YYYY")
-                    thumbnail {
-                      childImageSharp {
-                        gatsbyImageData(
-                          placeholder: BLURRED
-                          layout: FULL_WIDTH
-                        )
-                      }
+      const data = useStaticQuery(graphql`
+        query postList {
+          allMdx(
+            sort: { fields: [frontmatter___date], order: DESC }
+            filter: { frontmatter: { published: { ne: false } } }
+          ) {
+            edges {
+              node {
+                id
+                frontmatter {
+                  date(formatString: "ddd, DD MMM YYYY")
+                  thumbnail {
+                    childImageSharp {
+                      gatsbyImageData(placeholder: BLURRED, layout: FULL_WIDTH)
                     }
                   }
                 }
               }
             }
           }
-        `);
-
+        }
+      `);
+      // query length changed from 2 to 0
+      if (this.state.results.length > 0 && this.state.query.length > 0) {
         return (
           <div>
             <div className="bg-gray-50 text-gray-900 py-2">
@@ -252,13 +248,13 @@ class Search extends Component {
     //index - a flexsearch index instance (variables set in gatsby-config)
     //store - object that stores the indexed gatsby nodes where the id of each node corresponds to the id the filter, according with flexsearch.js best practices (https://github.com/nextapps-de/flexsearch#best-practices)).
 
-    var index = window.__FLEXSEARCH__.en.index;
-    var store = window.__FLEXSEARCH__.en.store;
+    let index = window.__FLEXSEARCH__.en.index;
+    let store = window.__FLEXSEARCH__.en.store;
 
     if (!query || !index) {
       return [];
     } else {
-      var results = [];
+      let results = [];
       // search the indexed fields
       Object.keys(index).forEach((idx) => {
         results.push(