-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added to Resend.php Facade: Contact, Audience and Batch methods #70
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting this PR @cheddZy This is a great addition but I think we can make it better. Instead of using actual methods in the Facade class, we should add a comment to the top of the class to make the developer experience better. Something like the Laravel DB Facade:
The reason I suggest this is because the underlying class that supports this Facade already has the methods that the Facade class defines. Eg. |
Hey - great suggestion, I'll get right on that. Completely slipped my mind we can do it with PHPDoc this way! |
Preoccupied right now but I noticed that I forgot to add some PHPDoc comments for the methods inside the class. I'll get on that in a little bit. |
I've approved automated tests for this PR. I'll also do some manual testing shortly. |
Apologies that I didn’t get time to review this earlier, but I’m really liking the latest changes. 💯 |
No worries, thanks for the quick reply! Whenever you get the time for it let me know if there's anything else I can improve. It's a pretty small change but hoping it's meaningful enough. |
Small addition for missing methods to the Facade for better developer UX.