Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear timeout in sync #116

Merged
merged 1 commit into from
May 13, 2024
Merged

Clear timeout in sync #116

merged 1 commit into from
May 13, 2024

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented May 8, 2024

If this timeout is not cleared, a program will not halt until the timeout elapses even in the case where the durable promise completes.

If this timeout is not cleared, a program will not halt until the
timeout elapses even in the case where the durable promise
completes.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.23%. Comparing base (bf05d61) to head (8d6a94f).

Files Patch % Lines
lib/core/promises/promises.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   81.21%   81.23%   +0.01%     
==========================================
  Files          22       22              
  Lines        1331     1332       +1     
  Branches      361      336      -25     
==========================================
+ Hits         1081     1082       +1     
- Misses        242      250       +8     
+ Partials        8        0       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit 19549fd into main May 13, 2024
2 checks passed
@dfarr dfarr deleted the fix/clear-sync-timeout branch May 13, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants