-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Namespaces #56
Conversation
I did it so we can have |
Go ahead. We're renaming everything already anyway. 🙂 |
@danhunsaker I think I got everything now. At least I can no longer find references to the old class names. Didn't yet really proof-read the documentation though |
No idea why I moved this back to main, it's meant to stay on develop. Can you rebase? |
I opened it against |
This is a request for comments on introducing namespaces to php-resque 🙂
The files are reorganized quite a bit to make namespaces more natural. I summarize as best as I can:
lib/Exceptions
DontCreate
toDoNotCreateException
DontPerform
toDoNotPerformException
lib\Job
lib\Failure
ResqueWorker
andSchedulerWorker
and moved tolib/Worker
Resque_Failure
has been renamed toFailureHandler
Resque_Failure
worked with Failures, but wasn't one itselfResque_Job
has been renamed toJobHandler
.Resque_Failure
. Additionally this would also allow us to introduce an actual Job class later that can be used for inheritanceCode and code comments have been updated, but there's a chance I missed some. Unit tests are updated as well though, and pass. However, I didn't update documentation until the actual implementation is agreed upon.
PR is based on #55, because working with the unit tests was easier that way.
Fixes #36