Fix compatibility with redis-rb 4.6.0 #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #191
Fix: redis/redis-rb#1069
Fix: redis/redis-rb#1088
In redis-rb 4.6.0, the object yielded by
multi
andpipelined
is an unsynchronized
PipelinedConnection
object.This changed opened a thread safety issue in Redis::Namespace:
redis.multi do
, setsNamespace#redis = PipelinedConnection
multi
block is called on the pipelined connectioncc @ArturT, @sergio91pt (extra testing welcome)