Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug on inheritance of DrawEvent from base class #45

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fixing bug on inheritance of DrawEvent from base class #45

merged 1 commit into from
Apr 7, 2022

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Apr 6, 2022 •
edited by pull-request-badge bot
Loading

juanangp 4

After new changes in the code, it seems that DrawEvent is not working for some inherited classes from TRestEvent

This PR fix this bug by replacing:

- TPad* DrawEvent(TString option = "");
+ TPad* DrawEvent(const TString& option = "");

@juanangp juanangp added the bug Something isn't working label Apr 6, 2022
@juanangp juanangp requested review from jgalan and lobis April 6, 2022 07:57
@jgalan jgalan merged commit 105d4bb into master Apr 7, 2022
@jgalan jgalan deleted the DrawEventFix branch April 7, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@lobis lobis Awaiting requested review from lobis

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanangp @jgalan