Merge pull request #393 from rest-for-physics/nkx111-single-event-file

Fix bug when processing files with a single event
rest-for-physics · Apr 28, 2023 · 324cf3d · 324cf3d
2 parents babeff3 + 39568e8
commit 324cf3d
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 26 deletions.
diff --git a/pipeline/ValidateTrees.C b/pipeline/ValidateTrees.C
@@ -59,6 +59,16 @@ Int_t ValidateTrees(const char* validationFilename, const char* inputFilename =
                 printf("  value: %.15f, should be: %.15f\n", (*inputObservableVector)[m],
                        (*validationObservableVector)[m]);
 
+                cout << "Validation vector contents: " << endl;
+                for (int m = 0; m < (*validationObservableVector).size(); m++)
+                    cout << (*validationObservableVector)[m] << "\t";
+                cout << endl;
+
+                cout << "Results vector contents: " << endl;
+                for (int m = 0; m < (*inputObservableVector).size(); m++)
+                    cout << (*inputObservableVector)[m] << "\t";
+                cout << endl;
+
                 if (!TMath::IsNaN((*inputObservableVector)[m] - (*validationObservableVector)[m]) &&
                     abs(((*inputObservableVector)[m] - (*validationObservableVector)[m]) /
                         (*inputObservableVector)[m]) < 1e-15) {

diff --git a/pipeline/trex/validation.root b/pipeline/trex/validation.root
diff --git a/source/framework/core/src/TRestRun.cxx b/source/framework/core/src/TRestRun.cxx
@@ -828,36 +828,40 @@ Int_t TRestRun::GetNextEvent(TRestEvent* targetevt, TRestAnalysisTree* targettre
         //}
         fCurrentEvent++;
     } else {
-        RESTDebug << "TRestRun: getting next event from root file" << RESTendl;
-        if (fAnalysisTree == nullptr) {
-            RESTWarning << "error to get event from input file, missing analysis tree from input file"
-                        << RESTendl;
-            eve = nullptr;
+        if (eve == nullptr) {
+            RESTDebug << "TRestRun::GetNextEvent(): input event has not been initialized!" << RESTendl;
         } else {
-            if (fCurrentEvent >= fAnalysisTree->GetTree()->GetEntriesFast()) {
+            RESTDebug << "TRestRun: getting next event from root file" << RESTendl;
+            if (fAnalysisTree == nullptr) {
+                RESTWarning << "error to get event from input file, missing analysis tree from input file"
+                            << RESTendl;
                 eve = nullptr;
             } else {
-                if (targettree != nullptr) {
-                    // normal reading procedure
-                    eve->Initialize();
-                    fBytesRead += fAnalysisTree->GetEntry(fCurrentEvent);
-                    targettree->SetEventInfo(fAnalysisTree);
-                    for (int n = 0; n < fAnalysisTree->GetNumberOfObservables(); n++)
-                        targettree->SetObservable(n, fAnalysisTree->GetObservable(n));
-                }
-                if (fEventTree != nullptr) {
-                    if (fEventTree->IsA() == TChain::Class()) {
-                        Long64_t entry = fEventTree->LoadTree(fCurrentEvent);
-                        fBytesRead += ((TBranch*)fEventTree->GetTree()->GetListOfBranches()->UncheckedAt(
-                                           fEventBranchLoc))
-                                          ->GetEntry(entry);
-                    } else {
-                        fBytesRead +=
-                            ((TBranch*)fEventTree->GetListOfBranches()->UncheckedAt(fEventBranchLoc))
-                                ->GetEntry(fCurrentEvent);
+                if (fCurrentEvent >= fAnalysisTree->GetTree()->GetEntriesFast()) {
+                    eve = nullptr;
+                } else {
+                    if (targettree != nullptr) {
+                        // normal reading procedure
+                        eve->Initialize();
+                        fBytesRead += fAnalysisTree->GetEntry(fCurrentEvent);
+                        targettree->SetEventInfo(fAnalysisTree);
+                        for (int n = 0; n < fAnalysisTree->GetNumberOfObservables(); n++)
+                            targettree->SetObservable(n, fAnalysisTree->GetObservable(n));
+                    }
+                    if (fEventTree != nullptr) {
+                        if (fEventTree->IsA() == TChain::Class()) {
+                            Long64_t entry = fEventTree->LoadTree(fCurrentEvent);
+                            fBytesRead += ((TBranch*)fEventTree->GetTree()->GetListOfBranches()->UncheckedAt(
+                                               fEventBranchLoc))
+                                              ->GetEntry(entry);
+                        } else {
+                            fBytesRead +=
+                                ((TBranch*)fEventTree->GetListOfBranches()->UncheckedAt(fEventBranchLoc))
+                                    ->GetEntry(fCurrentEvent);
+                        }
                     }
+                    fCurrentEvent++;
                 }
-                fCurrentEvent++;
             }
         }
     }

diff --git a/source/framework/core/src/TRestThread.cxx b/source/framework/core/src/TRestThread.cxx
@@ -190,14 +190,14 @@ bool TRestThread::TestRun() {
         }
 
         fOutputEvent = ProcessedEvent;
-        fHostRunner->GetNextevtFunc(fInputEvent, fAnalysisTree);
         if (fOutputEvent != nullptr) {
             RESTDebug << "Output Event ---- " << fOutputEvent->ClassName() << "(" << fOutputEvent << ")"
                       << RESTendl;
             break;
         } else {
             RESTDebug << "Null output, trying again" << RESTendl;
         }
+        fHostRunner->GetNextevtFunc(fInputEvent, fAnalysisTree);
     }
     if (fOutputEvent == nullptr) {
         // fOutputEvent = fProcessChain[fProcessChain.size() - 1]->GetOutputEvent();