-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove using namespace std from header files #156
Comments
I think its enough that when you work on some file, we try to also remove these kind of things in the same PR. We just need everyone to keep these things in mind! |
It could probably achieved quickly by find and replace any Then find and replace This could be done only at header files. Since we can still do |
In fact we should also replace many others such as On the other hand, I prefer to do these changes in a separate PR rather than in other PR that are not connected with this issue. |
restG4 |
Several instances to
using namespace std
are found in several header files, which is considered bad coding practise:https://stackoverflow.com/questions/1452721/why-is-using-namespace-std-considered-bad-practice
Here a list of the header files where I have found
using namespace std
in the code:However the required changes in the code could be larger than these header files, as has been pointed in #124 for TRestAnalysisPlot.h
I am willing to give a hand on this issue, but I think we should divide the work because the load can be large.
The text was updated successfully, but these errors were encountered: