Support Latest Geant4 Versions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usages. May change physics output!
…ink). May have unintended effects if both functions aren't equivalent.
… recommended alternative
…ons instead of `add_definitions`
|
Thanks to @glorialuzon I added back the removed EM commands in fd0e477. Now it looks like the pipeline is passing without any change in physics results and it also compiles with Geant4 11.0.1. I leave here this useful link: https://geant4.web.cern.ch/node/1620 It is ready to be merged after review by @jgalan and @glorialuzon. |
glorialuzon
approved these changes
Mar 30, 2022
jgalan
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #31.
This PR:
G4EmProcessOptionsclass. Old usage is now deprecated 664ce98. Change should not have any effect on the physics.G4RadioactiveDecayto what looks like is the new API for the same usage. It doesn't look like it should affect the physics, but it would be nice if someone can check this.10.2.9Geant4 versions, since that version is now too old and there is probably some issue with the changes in this PR for versions that old.