TRestMetadata: undefine = operator method overload #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will cause double free problems if we use
=
or copy constructor for metadata classes. The reason is that the data memberfElement
as a pointer will also be copied. And when we delete the two metadata classes, the same pointer will be deleted twice. For example:In this PR I undefined the
=
operator. Now the second line doesn't work, and avoids this problem.Now to copy metadata or to use the object(instead of pointer), one can use
Clone()
, or reference: