Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FindROOT.cmake in case thisroot.sh wasn't sourced #136

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Fix FindROOT.cmake in case thisroot.sh wasn't sourced #136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0e11da
clean up cmake formatting
Vindaar Feb 14, 2022
071f2af
[Windows] error if $ROOTSYS environment variable undefined
Vindaar Feb 14, 2022
b7bcef5
[unix] do not use $ROOTSYS, use `root-config --bindir`
Vindaar Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions cmake/FindROOT.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,45 @@
# - Finds ROOT instalation
# This module sets up ROOT information
# This module sets up ROOT information
# It defines:
# ROOT_FOUND If the ROOT is found
# ROOT_INCLUDE_DIR PATH to the include directory (deprecated)
# ROOT_INCLUDE_DIRS PATH to the include directory
# ROOT_LIBRARIES Most common libraries
# ROOT_LIBRARY_DIR PATH to the library directory
# ROOT_LIBRARY_DIR PATH to the library directory
# ROOT_BIN_DIR PATH to the excutables directory
# ROOT_PYTHONVER Compatible python version string

# First search for ROOTConfig.cmake on the path defined via user setting
# First search for ROOTConfig.cmake on the path defined via user setting
# ROOT_DIR

if (CMAKE_SYSTEM_NAME MATCHES "Windows")

if(DEFINED ENV{ROOTSYS})
set(ROOTSYS $ENV{ROOTSYS})
set(ROOTSYS $ENV{ROOTSYS})
else()
message(FATAL_ERROR "ROOTSYS environment variable is undefined. Did you forget to source the `thisroot.bat`?")
endif()

if(NOT ROOTSYS)
set(ROOT_FOUND FALSE)
set(ROOT_FOUND FALSE)
else()
set(ROOT_FOUND TRUE)

set(ROOT_LIBRARY_DIR ${ROOTSYS}/lib)
set(ROOT_INCLUDE_DIRS ${ROOTSYS}/include)
set(ROOT_BIN_DIR ${ROOTSYS}/bin)
set(ROOTCINT_EXECUTABLE ${ROOTSYS}/bin/rootcint.exe)
set(GENREFLEX_EXECUTABLE ${ROOTSYS}/bin/genreflex.exe)
set(GENREFLEX_EXECUTABLE ${ROOTSYS}/bin/genreflex.exe)

set(CMAKE_FIND_LIBRARY_PREFIXES "lib")
set(CMAKE_FIND_LIBRARY_SUFFIXES ".lib" ".dll")
set(ROOT_LIBRARIES)
foreach(_cpt Core Imt RIO Net Hist Gui Eve RGL Gdml Geom Graf Graf3d Gpad Tree TreePlayer Rint Postscript Matrix Physics MathCore Thread MultiProc Minuit)
find_library(ROOT_${_cpt}_LIBRARY ${_cpt} HINTS ${ROOT_LIBRARY_DIR})
if(ROOT_${_cpt}_LIBRARY)
mark_as_advanced(ROOT_${_cpt}_LIBRARY)
list(APPEND ROOT_LIBRARIES ${ROOT_${_cpt}_LIBRARY})
endif()
if(ROOT_${_cpt}_LIBRARY)
mark_as_advanced(ROOT_${_cpt}_LIBRARY)
list(APPEND ROOT_LIBRARIES ${ROOT_${_cpt}_LIBRARY})
endif()
endforeach()
if(ROOT_LIBRARIES)
list(REMOVE_DUPLICATES ROOT_LIBRARIES)
Expand All @@ -51,26 +53,21 @@ else()

if(NOT ROOT_CONFIG_EXECUTABLE)
set(ROOT_FOUND FALSE)
else()
else()
set(ROOT_FOUND TRUE)


execute_process(
COMMAND ${ROOT_CONFIG_EXECUTABLE} --incdir
execute_process(
COMMAND ${ROOT_CONFIG_EXECUTABLE} --incdir
OUTPUT_VARIABLE ROOT_INCLUDE_DIRS
OUTPUT_STRIP_TRAILING_WHITESPACE)

execute_process(
COMMAND ${ROOT_CONFIG_EXECUTABLE} --libdir
execute_process(
COMMAND ${ROOT_CONFIG_EXECUTABLE} --libdir
OUTPUT_VARIABLE ROOT_LIBRARY_DIR
OUTPUT_STRIP_TRAILING_WHITESPACE)


set(ROOTCINT_EXECUTABLE $ENV{ROOTSYS}/bin/rootcint)
set(GENREFLEX_EXECUTABLE $ENV{ROOTSYS}/bin/genreflex)

execute_process(
COMMAND ${ROOT_CONFIG_EXECUTABLE} --version
COMMAND ${ROOT_CONFIG_EXECUTABLE} --version
OUTPUT_VARIABLE ROOT_VERSION
OUTPUT_STRIP_TRAILING_WHITESPACE)

Expand All @@ -84,15 +81,18 @@ else()
OUTPUT_VARIABLE ROOT_BIN_DIR
OUTPUT_STRIP_TRAILING_WHITESPACE)

# Make variables changeble to the advanced user
set(ROOTCINT_EXECUTABLE ${ROOT_BIN_DIR}/rootcint)
set(GENREFLEX_EXECUTABLE ${ROOT_BIN_DIR}/genreflex)

# Make variables changeble to the advanced user
mark_as_advanced(ROOT_CONFIG_EXECUTABLE)
endif()
endif()


if (NOT ROOT_FOUND)
message(FATAL_ERROR "ROOT required, but not found")
message(FATAL_ERROR "ROOT required, but not found")
else()
message(STATUS "Find ROOT ${ROOT_VERSION} in ${ROOT_BIN_DIR}")
message(STATUS "Find ROOT ${ROOT_VERSION} in ${ROOT_BIN_DIR}")
endif()