Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CMake for inclusion of REST via find_package #147

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Mar 9, 2022

lobis 29

Changes to the CMake files to support inclusion of REST via find_package(REST).

Added new command: rest-config --prefix which returns the installation path of REST (doesn't have to be the same as the current REST_PATH).

When doing find_package(REST) it will check that the current REST_PATH and the installation path of REST match. It will throw an error if they don't.

@lobis lobis requested review from jgalan and nkx111 March 9, 2022 12:24
@lobis
Copy link
Member Author

lobis commented Mar 9, 2022

relevant PR: rest-for-physics/restG4#33

@lobis lobis marked this pull request as ready for review March 9, 2022 18:03
@lobis lobis requested a review from a team March 9, 2022 18:04
Copy link
Member

@jgalan jgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but how could it happen that rest-config --prefix is not the same as REST_PATH?

@lobis
Copy link
Member Author

lobis commented Mar 10, 2022

Ok, but how could it happen that rest-config --prefix is not the same as REST_PATH?

The user could have changed the REST_PATH env variable after sourcing REST, rest-config --prefix is safer in general, in a similar way to root-config --prefix vs $ROOTSYS.

@lobis lobis requested review from a team and DavidDiezIb March 10, 2022 08:41
@lobis lobis merged commit c667aaf into master Mar 10, 2022
@lobis lobis deleted the lobis-patch-cmake_find_package branch March 10, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants