Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing override, looks problematic with root #179

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Apr 6, 2022

After new changes in the code, it seems that root doesn't like override method, see below:

image

Fix this error by removing override from TRestVolumeHits

@juanangp juanangp requested review from jgalan and lobis April 6, 2022 07:54
@juanangp juanangp merged commit 26aec05 into master Apr 7, 2022
@juanangp juanangp deleted the DrawEventFix branch April 7, 2022 12:04
@nkx111
Copy link
Member

nkx111 commented Apr 8, 2022

You need to use ClassDefOverride instead ClassDef for cint, in case you have override keyword in the header.

This is not ROOT issue, this is a favor of gcc. Once you have one method marked with override, you need to mark override for all. On the other hand, ClassDef macro adds several methods implementing those from TObject, which in this case shall also be marked with override keyword. We can use ClassDefOverride macro to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants