Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor but urgent fixes #206

Merged
merged 4 commits into from
May 11, 2022
Merged

Minor but urgent fixes #206

merged 4 commits into from
May 11, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented May 11, 2022 •
edited by pull-request-badge bot
Loading

jgalan Ok: 6

This PR adds the following minor changes:

  • restRoot now will warn the user if we use restRoot file.root and file.root does not exist.
  • TRestRun::ReadFileInfo bug fixed.
  • TRestMetadata::GetSearchPath. Added REST_PATH/examples directory to the default search paths.
  • framework/CMakeList fixed a compilation issue related to std::filesystem

@jgalan jgalan changed the title Jgalan minor fixes Minor but urgent fixes May 11, 2022
@jgalan jgalan requested review from lobis, juanangp and a team May 11, 2022 18:45
@jgalan jgalan marked this pull request as ready for review May 11, 2022 18:46
@jgalan jgalan merged commit e63944c into master May 11, 2022
@jgalan jgalan deleted the jgalan_minor_fixes branch May 11, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradAltenmueller KonradAltenmueller KonradAltenmueller approved these changes

@lobis lobis lobis approved these changes

@juanangp juanangp Awaiting requested review from juanangp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgalan @lobis @KonradAltenmueller