TRestAnalysisPlot. Now addFile supports filename patterns #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradAltenmueller
approved these changes
Jun 15, 2022
|
Not sure why the tests are failing on the latest pipeline https://gitlab.cern.ch/rest-for-physics/framework/-/jobs/22549400 It was not the case on the first commit I pushed to this PR |
|
Any idea why pipeline is failing? Seems connected to restG4 @lobis? |
|
Well, maybe just removing "Build and Test" from Gitlab pipeline would make it. |
Okay, I think we can fix it quickly otherwise I will remove it |
added 2 commits
June 15, 2022 13:48
…ramework into jgalan_analysis_plots
cmargalejo
approved these changes
Jun 15, 2022
Should be fixed now, but we have to check |
|
In principle if those build-tests are already at GitHub, it could reduce the workload at the Gitlab pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow
addFiledefinitions insideTRestAnalysisPlotas<addFile name="/path/to/file/Run*.root" />