Fixing metadata retrieval from entries that contain chidren at TRestRun and TRestProcessRunner #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch to allow loading metadata objects and processes inside
TRestRun
andTRestProcessRunner
that contain child elements, such as the recently addedTRestAxionWolterOptics
.The problem was connected with the fact that the recently added
InstantiateChildMetadata
method requires access to the RML file. This problem could have been solved by implementing an additionalLoadConfigFromBuffer
that reads the input fromconfigBuffer
since that was available and with the proper contents.However a quick solution for me was to pass the config filename to the additionally/new instantiated classes.
Please approve (I need the changes) and create and issue in case you find a better solution.