Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing metadata retrieval from entries that contain chidren at TRestRun and TRestProcessRunner #265

Merged
merged 6 commits into from
Jul 13, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Jul 12, 2022

jgalan Ok: 6

This PR is a patch to allow loading metadata objects and processes inside TRestRun and TRestProcessRunner that contain child elements, such as the recently added TRestAxionWolterOptics.

The problem was connected with the fact that the recently added InstantiateChildMetadata method requires access to the RML file. This problem could have been solved by implementing an additional LoadConfigFromBuffer that reads the input from configBuffer since that was available and with the proper contents.

However a quick solution for me was to pass the config filename to the additionally/new instantiated classes.

Please approve (I need the changes) and create and issue in case you find a better solution.

@jgalan
Copy link
Member Author

jgalan commented Jul 12, 2022

I am getting the following compilation error on the GitHub pipeline

/__w/framework/framework/framework/source/libraries/track/src/TRestTrackLinearizationProcess.cxx: In member function 'void TRestTrackLinearizationProcess::GetHitsProjection(TRestVolumeHits*, const int&, TRestVolumeHits&)':
/__w/framework/framework/framework/source/libraries/track/src/TRestTrackLinearizationProcess.cxx:150:42: error: no matching function for call to 'TRestVolumeHits::GetX()'
  150 |         auto cl = GetBestNodes(hits->GetX(), hits->GetZ(), hits->GetEnergyVector(), nodes);

@jgalan jgalan requested review from lobis, nkx111 and juanangp July 12, 2022 13:26
@jgalan jgalan marked this pull request as ready for review July 12, 2022 13:27
@jgalan
Copy link
Member Author

jgalan commented Jul 12, 2022

Dont understand why it gets stuck here: https://gitlab.cern.ch/rest-for-physics/framework/-/jobs/23207995

Perhaps it is the python version?

@nkx111
Copy link
Member

nkx111 commented Jul 12, 2022

Dont understand why it gets stuck here: https://gitlab.cern.ch/rest-for-physics/framework/-/jobs/23207995

Perhaps it is the python version?

I created #264 to fix it. Looks like some infinite loop arises because of asymmetric brakets in the comment.

@jgalan jgalan merged commit f6874df into master Jul 13, 2022
@jgalan jgalan deleted the jgalan_metadata_fixes branch July 13, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants