Few string and TRestAnalysisPlot enhancements #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgalan
requested review from
lobis,
nkx111 and
cmargalejo
and removed request for
lobis
lobis
reviewed
Jul 13, 2022
…sion only to numbers
…ressions contained between simple quotes ''
…ethod documentation
jgalan
changed the title
|
Wow! I reverted the changes and it is passing! |
…ing additional method documentation"" This reverts commit eb304e9.
|
Perhaps the addition of |
|
I updated the description. This PR brings new really cool changes at |
KonradAltenmueller
approved these changes
Jul 14, 2022
lobis
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRestAnalysisPlot:<panel font_size="0.4" precision="4" >will allow for 4-digits after the "." in a float number.<histowill allow an additional parameterweightthat will use a branch to weight the filling of the histogram. This effect could be achieved previously by defining manually thecutStringdefinition. Now, however we can do:<histo name="hName" weight="efficiency" />whereefficiencyis a branch existing in the tree.Modified methods are
TRestMetadata::GetDataMemberValuesandTRestRun::ReplaceMetadataMember/s. The default precision is 0 (i.e. the method will work as it was doing before).REST_StringHelper::ReplaceMathematicalExpressionswill allow to include a sub-expression by delimiting the sub-expression using single quotes `.REST_StringHelper::CropWithPrecisionmethod added.