-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MPFR library at the framework level #276
Conversation
Plz @lobis could you check it is the appropriate way to introduce this inside CMakeLists? |
I made some modifications. Instead of throwing an error when not found I set it to warning, I don't think we want to give an error when this library is not found right? The previous implementation relied on the In my machine using the pipeline docker image I don't need to specify this Maybe the |
Great addons @lobis, lets then approve and merge the changes? |
set(external_libs "${external_libs};-lmpfr") | ||
link_directories(${MPFR_LIB}) | ||
else () | ||
message(WARNING "MPFR library was not found. Adding the location to the installation path may solve this problem.\n Use -DMPFR_PATH=/path/to/mpfr/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add some flags if this library is not linked, then one can type rest-config --flags
to see if he can compile a MPFR-dependent REST library(like axionlib) based on this installation of REST
This PR simply brings the MPFR library to the framework level and not only for axionlib.
MPFR library allows calculations with any required number precision.
I will soon use it with a new class
TRestComplex
to do calculations with exact precision, but for the moment this change is required by the recent rest-for-physics/axionlib#12 PR.