Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing objects with kOverwrite flag instead of kWriteDelete #298

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Sep 13, 2022

lobis Ok: 13

Changed all the occurences of kWriteDelete for kOverwrite.

This avoids having random numbers after keys in the root file, such as:

root [1] .ls
TFile**         /tmp/tmp.NR4gQ6jbwZ/source/packages/restG4/examples/04.MuonScan/muons.root
 TFile*         /tmp/tmp.NR4gQ6jbwZ/source/packages/restG4/examples/04.MuonScan/muons.root
  KEY: TRestAnalysisTree        AnalysisTree;4  AnalysisTree
  KEY: TTree    EventTree;4     TRestGeant4EventTree
  KEY: TRestRun CosmicMuonRun;4 A basic muon test with 2 active volumes
  KEY: TRestGeant4Metadata      restG4 run;3    MuonsFromWall
  KEY: TRestGeant4PhysicsLists  default;3       First physics list implementation.
  KEY: TGeoManager      Geometry;1      Geometry imported from GDML

Not sure if there was a reason to use kWriteDelete in the first place @nkx111 @jgalan .

@lobis lobis requested review from jgalan, nkx111 and juanangp September 13, 2022 11:42
@jgalan
Copy link
Member

jgalan commented Sep 13, 2022

Not sure if there was a reason behind.

@lobis lobis marked this pull request as ready for review September 13, 2022 12:53
@lobis lobis merged commit c30eeb3 into master Sep 13, 2022
@lobis lobis deleted the lobis-overwrite branch September 13, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants