Fixing an issue with masks not rotating #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovoy
approved these changes
Nov 15, 2022
|
This PR just adds a definition that can be used to encapsulate code that requires MPFR libraries to be linked. |
jgalan
changed the title
lobis
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
I updated to only have a single definition of USE_MPFR. The position of this definition is updated as a result of this PR, I have not verified this is necessary but I assume it is (I thought I had checked when I placed it under the if initially, but I don't remember the details).
If you think everything is working as expected it looks good to me @jgalan
lobis
added a commit
that referenced
this pull request
Nov 18, 2022
jgalan
commented
Nov 18, 2022
jgalan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor update required by rest-for-physics/axionlib#31