Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix browser for newer root versions (6.26./10) and add icons to buttons #336

Merged
merged 5 commits into from
Nov 25, 2022
Merged

fix browser for newer root versions (6.26./10) and add icons to buttons #336

merged 5 commits into from
Nov 25, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Nov 24, 2022 •
edited by pull-request-badge bot
Loading

lobis Ok: 41

On latest root version (6.26/10) the browser is broken because we are hardcoding the icons path, which has been updated.

I also added icons to some of the buttons so they look better (in my opinion).

image

@lobis lobis added the bug Something isn't working label Nov 24, 2022
@lobis lobis requested review from jgalan, nkx111 and juanangp November 24, 2022 22:12
@lobis lobis marked this pull request as ready for review November 25, 2022 07:01
@lobis lobis requested a review from a team November 25, 2022 13:01
@lobis lobis merged commit 4cf0a2e into master Nov 25, 2022
@lobis lobis deleted the lobis-browser-icons branch November 25, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanangp juanangp juanangp approved these changes

@jgalan jgalan jgalan approved these changes

@nkx111 nkx111 Awaiting requested review from nkx111 nkx111 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lobis @jgalan @juanangp