Cmake fixes to clean up warnings during compilation #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgalan
changed the title
…ork into jgalan_cmake_fix
lobis
reviewed
Dec 19, 2022
lobis
reviewed
Dec 19, 2022
lobis
reviewed
Dec 19, 2022
juanangp
reviewed
Dec 19, 2022
juanangp
reviewed
Dec 19, 2022
lobis
reviewed
Dec 19, 2022
lobis
reviewed
Dec 19, 2022
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
lobis
reviewed
Dec 19, 2022
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
…ork into jgalan_cmake_fix
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
jgalan
commented
Dec 19, 2022
cmargalejo
approved these changes
Dec 22, 2022
juanangp
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will avoid some warnings that appear during compilation.
Some warnings seem to be related to the fact that we were generating dictionaries for classes that do not inherit from Object. This is my guess.
MacroRootDict.cmakeso that dictionary is not generated for some classes that do not inherit from TObject, and/or just do not need dictionary.I implemented a patch the best I could at
make/MacroRootDict.cmake, do not hesitate to improve the implementation of the present patch if you find a better way.Now compilation warnings will be considered errors so the pipeline will fail in case there are any warnings.
IMPORTANT. There are still a number of warnings that are hidden from the user, because I didn't manage to solve.
We may compile using
-DCMAKE_BUILD_TYPE=Debugto show all warnings.Other related PRs that MUST be merged together with this PR.
rest-for-physics/restG4#89
rest-for-physics/geant4lib#82
rest-for-physics/axionlib#43
rest-for-physics/tracklib#26
rest-for-physics/wimplib#4
rest-for-physics/rawlib#90
rest-for-physics/detectorlib#64
rest-for-physics/connectorslib#22